Fix lazy bindToMany relation caching to match eager-loaded collections#285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency in lazy bindToMany loading where the first property access returned a collection of related models, but the cached relation on subsequent access was stored as a grouped raw array keyed by the pivot foreign key.
With this change, lazy bindToMany now caches the relation as a proper Collection, matching the eager-loading path. Repeated access to many-to-many relations now stays consistent and related items continue to include pivot data as expected.
Also adds regression coverage for repeated lazy bindToMany access and updates the related query test expectations to match the corrected collection behavior.